Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Property] Correct AreaCode for Queensland to QLD #193

Open
3 tasks
johcarter opened this issue Jun 19, 2024 · 4 comments
Open
3 tasks

[Property] Correct AreaCode for Queensland to QLD #193

johcarter opened this issue Jun 19, 2024 · 4 comments
Assignees
Labels
major major release (breaking change)

Comments

@johcarter
Copy link
Contributor

Description

The ISO 3166-2 standard subdivision code for Queensland, Australia is QLD but it has always been QDL in the OED AreaCode list. The proposal is to correct it to QLD as part of the OED v4 release.

Reasons for change

To be in consistent with ISO standard

Scope of change

  • [ X] Location File
  • Accounts File
  • Reinsurance Scope
  • Reinsurance Info

Impact of change

It will be a breaking change for any OED file which uses value 'QDL' in the AreaCode field, which will no longer be valid.

@johcarter johcarter added the major major release (breaking change) label Jun 19, 2024
@johcarter johcarter changed the title Correct AreaCode for Queensland to QLD [All] Correct AreaCode for Queensland to QLD Jun 19, 2024
@johcarter johcarter self-assigned this Jun 19, 2024
@aiste-kalinauskaite
Copy link

@benhayes21 suggested that it might be worthwhile to support both for awhile until the old code is removed. This would be a smaller interruption to the vendors and users.
I would also suggest to discuss this with vendors who cover Australia, if they would be happy for a cold turkey approach (removing it straight away) or having a backup of the old and the new code for OED v4 (and perhaps removing the old in OED v5 or OED v6).
@johcarter

@johcarter
Copy link
Contributor Author

@mrQQish can you weigh in on this please?

@johcarter johcarter added minor minor release (non-breaking change) major major release (breaking change) and removed major major release (breaking change) minor minor release (non-breaking change) labels Jun 25, 2024
@johcarter
Copy link
Contributor Author

We will replace QDL with QLD in v4 unless there are any objections.

johcarter added a commit that referenced this issue Jul 10, 2024
@MattDonovan82
Copy link
Contributor

MattDonovan82 commented Jul 11, 2024

Agree to correct this to QLD. I don't think we need to support the incorrect code of QDL aswell. As OED v4.0.0 will be a major (breaking) update, I suggest we make it correct now rather than supporting both. QLD is the correct ISO2 code anyway so users should be using this.

sambles pushed a commit that referenced this issue Jul 17, 2024
sambles pushed a commit that referenced this issue Jul 17, 2024
@johcarter johcarter changed the title [All] Correct AreaCode for Queensland to QLD [Property] Correct AreaCode for Queensland to QLD Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major major release (breaking change)
Projects
Status: Done
Status: Todo
Status: Agreed and ready
Development

No branches or pull requests

3 participants