Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to Queensland code in v3.2 in Error #189

Closed
3 tasks
MattDonovan82 opened this issue Jun 14, 2024 · 4 comments · Fixed by #190
Closed
3 tasks

Change to Queensland code in v3.2 in Error #189

MattDonovan82 opened this issue Jun 14, 2024 · 4 comments · Fixed by #190

Comments

@MattDonovan82
Copy link
Contributor

Error change to Queensland code in v3.2

Description

The code for Queensland has been changed from 'QDL' to 'QLD' in v3.2 and was not included in the release notes or any other issue. This code should be 'QLD' and was probably a typo from when OED was developed by this needs to go back to 'QDL' for v3.3

Reasons for change

Will cause breaking changes in OED validation

Scope of change

  • [X ] Location File
  • Accounts File
  • Reinsurance Scope
  • Reinsurance Info

Impact of change

This will be released as v3.3

Data type, default values, are blanks allowed, list valid values

Field Name Data type Default values Blanks allowed Valid values
AreaCode nvarchar(20) n/a yes
@MattDonovan82
Copy link
Contributor Author

@johcarter @aiste-kalinauskaite @benhayes21, I will make this revision in the spec and release as OED v3.3.0

@MattDonovan82
Copy link
Contributor Author

we can maybe correct back to QLD in v4?

@sambles sambles linked a pull request Jun 14, 2024 that will close this issue
@sambles sambles mentioned this issue Jun 14, 2024
@MattDonovan82
Copy link
Contributor Author

Closed as corrected and released in OED v3.3

@aiste-kalinauskaite
Copy link

The change was introduced in v3.1 and remained in v3.2. Both versions were affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants