Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an XML 1.1 encoder #73

Open
paul-redwood opened this issue Jun 6, 2024 · 1 comment
Open

Add an XML 1.1 encoder #73

paul-redwood opened this issue Jun 6, 2024 · 1 comment

Comments

@paul-redwood
Copy link

The current toXML method escapes for XML 1.0. Specifically the difference is that XML1.1 allows all characters [#x1-#x1F], whereas XML 1.0 only allows some of these.

As an aside, the current XML encoder has a comment that these invalid characters should be replaced with a � character, however the escaper actually replaces these all with a space character. I was under the impression that these methods didn't do sanitisation, they only did escaping?

@jmanico
Copy link
Member

jmanico commented Jun 6, 2024

Are you available to send us a PR to address this issue? Thank you for your comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants