Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to node 12 #150

Closed
5 tasks done
UlisesGascon opened this issue Aug 5, 2019 · 3 comments
Closed
5 tasks done

Migration to node 12 #150

UlisesGascon opened this issue Aug 5, 2019 · 3 comments

Comments

@UlisesGascon
Copy link
Collaborator

UlisesGascon commented Aug 5, 2019

Context

Tasks

  • Add support for Node 12
  • Add support for Node 10
  • Add support for Node 8
  • Update travis.yaml with the builds for those environments
  • Update the readme.md with the relevant info

Assignation

  • This tasks is open for assignation, just claim it (as reply to this) and submit your PR ;-)

Important

@binarymist
Copy link
Collaborator

Pretty sure last time I suggested we upgrade @ckarande wasn't that keen. Hopefully this has changaed?

@UlisesGascon UlisesGascon mentioned this issue Aug 6, 2019
6 tasks
@ckarande
Copy link
Member

ckarande commented Aug 6, 2019

@binarymist Yes, I know this item has been in the list for a while. I am good to take it now. Having the integration test coverage now allows us to do the necessary validations in an efficient way. 👍

@UlisesGascon UlisesGascon self-assigned this Aug 7, 2019
@UlisesGascon UlisesGascon mentioned this issue Aug 7, 2019
5 tasks
@UlisesGascon
Copy link
Collaborator Author

This was closed by #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants