Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Threat_Modeling_Cheat_Sheet.md #1444

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

sebob
Copy link
Contributor

@sebob sebob commented Jul 5, 2024

With reference to the discussion #1430

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

🚩 If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as [TEXT](URL)
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue, please finish your PR text with the following line:

This PR covers issue #.

Thank you again for your contribution 😃

With reference to the discussion OWASP#1430
Copy link
Collaborator

@mackowski mackowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebob
Copy link
Contributor Author

sebob commented Jul 8, 2024

@jmanico , @szh Do you have any comments? thoughts on the changes I propose?

@szh
Copy link
Collaborator

szh commented Jul 8, 2024

@sebob Thanks for the PR! I wonder if the new paragraphs should be before the paragraph starting "Regardless of how a DFD or comparable model is generated..."
Also, since this is a cheat sheet, I think it should be possible to combine the three new paragraphs into one short paragraph of about 3-5 sentences. Brevity is very important for the usability of the cheat sheets.

@jmanico jmanico merged commit 64f4e10 into OWASP:master Jul 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants