Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: update readme (use latest tag) #4131

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

landam
Copy link
Member

@landam landam commented Aug 4, 2024

Readme files suggest to create Docker images for GRASS stable from releasebranch_8_2. The current stable branch is releasebranch_8_4. To avoid outdated instructions this PR suggests to checkout latest tag instead (completion of #2969)

The run example shows how to run grass binary instead of generic shell.

@landam landam modified the milestones: 8.5.0, 8.4.1 Aug 4, 2024
@landam landam requested a review from neteler August 4, 2024 16:13
@github-actions github-actions bot added docker Docker related docs labels Aug 4, 2024
@landam landam self-assigned this Aug 4, 2024
@neteler neteler added the backport to 8.4 PR needs to be backported to release branch 8.4 label Aug 4, 2024
@echoix
Copy link
Member

echoix commented Aug 4, 2024

The title confused me at first, as I thought you were suggesting for users to use each docker image's "latest" tag, which we decided a while back that it didn't mean latest release, but latest and greatest commit (that I would call more like "beta").

However, the changes here are more of using git to return the latest (in the sense of last available git tag for a branch).

Also, it seems that before, the syntax of the commands were platform-agnostic, now they use command substitution, that works well for Linux (at least with bash), but for cmd.exe or powershell, won't work as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to 8.4 PR needs to be backported to release branch 8.4 docker Docker related docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants