Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New revisions of chartdatum norway v2023b #112

Merged
merged 10 commits into from
Dec 1, 2023

Conversation

himsve
Copy link
Contributor

@himsve himsve commented Nov 24, 2023

New separation model model between ETRS89 ell. height and CD_NORWAY

The GeoTiff no_kv_CD_above_Ell_ETRS89_v2023b.tif is the lastest version of the vertical offset grid (separation model) from ETRS89 ell. heights (EPSG:4937) to CD_NORWAY depths (EPSG:9672).

  • no_kv_CD_above_Ell_ETRS89_v2023b is a replacement of the current version no_kv_CD_above_Ell_ETRS89_v2021a
  • no_kv_CD_above_Ell_ETRS89_v2023b.tif consists of two bands, vertical offsets (band 1) and vertical offset standard deviations (band 2). Band 2 is marked vertical_offset_accuracy in meters as GDAL Metadata. So far vertical accuracy metadata is missing in PROJ.
  • The modified transformation is requested in EPSG, but not yet published.

Copy link
Contributor

@jjimenezshaw jjimenezshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really want to delete the old file? Or add a new one, leaving the old one?
I see in EPSG the previous transformation https://epsg.org/transformation_9884/ETRS89-to-CD-Norway-depth-1.html
Are you going to delete it, or create a new one?
(In other countries it is usually a new one with a better accuracy, leaving the old one for consistency with previous data)

copyright_and_licenses.csv Outdated Show resolved Hide resolved
@jjimenezshaw
Copy link
Contributor

Are you going to delete it, or create a new one?

Actually I see it was already superseded by https://epsg.org/transformation_10130/ETRS89-to-CD-Norway-depth-2.html, but not deleted.

@rouault
Copy link
Member

rouault commented Nov 24, 2023

The metadata of the grid is incorrect. It should not be TYPE=VERTICAL_OFFSET_VERTICAL_TO_VERTICAL, but TYPE=VERTICAL_OFFSET_GEOGRAPHIC_TO_VERTICAL

I also think we should let the previous file for reproducability for older transformations. The EPSG supersession mechanism should ensure the new grid is used by default, once it has made its way through EPSG.

@@ -60,7 +60,7 @@ Horizontal triangulation to transform coordinates from ETRS89 (EPSG:4258) to NGO
*Source CRS*: EPSG:4937 (ETRS89 ellipsoidal heights)
*Target CRS*: EPSG:9672 (Chart datum Norway heights)

* no_kv_CD_above_Ell_ETRS89_v2021a.tif
* no_kv_CD_above_Ell_ETRS89_v2023b.tif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace or add?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be replaced

files.geojson Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@rouault
Copy link
Member

rouault commented Nov 27, 2023

@himsve You can drop the changes in the generated files (files.geojson, index.html) frmo the PR if that makes your life easier. I can easily refresh them on my side once this PR is merged. I suspect you might perhaps have some git issues with CRLF if you work on Windows.

copyright_and_licenses.csv Outdated Show resolved Hide resolved
@rouault
Copy link
Member

rouault commented Nov 30, 2023

@kbevers Is it fine to merge that right now in master, or will that cause trouble in your 1.16 release process?

@kbevers
Copy link
Member

kbevers commented Nov 30, 2023

Is it fine to merge that right now in master, or will that cause trouble in your 1.16 release process?

I prefer that you wait until 1.16 is done

@rouault rouault added this to the 1.17 milestone Dec 1, 2023
@rouault rouault merged commit d348f89 into OSGeo:master Dec 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants