added nginx and fixed erroneous web container build and run process #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joshua s brown libcurl openssl
…to BlakeNedved-nginx-new-web-build
JoshuaSBrown
changed the base branch from
JoshuaSBrown-libcurl-openssl
to
devel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR was to place a reverse proxy (NGINX) infront of DataFed this provides us with the ability to easily switch between containers in preparation for production where you might want push traffic to different machines in the cases of an outage, i.e. having a maintenance page.
Acceptance
Before this PR can be merged the compose file needs to be fully tested. Ideally compose would be run as part of the end-to-end tests in the CI pipeline.