Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user control on resampling operations #11646

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Conversation

magnesj
Copy link
Member

@magnesj magnesj commented Aug 27, 2024

When resampling a rate curve, the last time period with no data is not affecting the computed range.

Allow user to set Accumulated or Rate for a summary curve. Default value is Auto, and Accumulated/Rate is derived from the summary address.

@magnesj magnesj requested a review from kriben August 27, 2024 12:51
@magnesj magnesj marked this pull request as ready for review August 27, 2024 12:51
Copy link
Collaborator

@kriben kriben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some failing tests to look at before merging.

ApplicationLibCode/Application/RiaSummaryDefines.cpp Outdated Show resolved Hide resolved
Default setting is Auto, and use the summary address to derive Accumulated/Rate. User can set curve type explicitly.
@magnesj magnesj merged commit 27c46a6 into dev Aug 28, 2024
19 checks passed
@magnesj magnesj deleted the observed-resampling branch August 28, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants