Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cell filter performance improvement #10550

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Cell filter performance improvement #10550

merged 4 commits into from
Aug 29, 2023

Conversation

jonjenssen
Copy link
Collaborator

Closes #10522

@jonjenssen jonjenssen marked this pull request as ready for review August 28, 2023 09:55
@jonjenssen jonjenssen enabled auto-merge (squash) August 28, 2023 13:46
magnesj
magnesj requested changes Aug 29, 2023
View reviewed changes
Copy link
Member

@magnesj magnesj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive performance improvement, very good. Please add some more comments to make it easier to understand the code

ApplicationLibCode/GeoMech/GeoMechVisualization/RivFemElmVisibilityCalculator.cpp Outdated Show resolved Hide resolved
ApplicationLibCode/GeoMech/GeoMechVisualization/RivGeoMechVizLogic.cpp Outdated Show resolved Hide resolved
ApplicationLibCode/GeoMech/GeoMechVisualization/RivFemElmVisibilityCalculator.cpp Outdated Show resolved Hide resolved
@jonjenssen jonjenssen merged commit 0a80761 into dev Aug 29, 2023
17 checks passed
@jonjenssen jonjenssen deleted the cellfilter_performance branch August 29, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnesj magnesj magnesj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Polygon Filter - performance issues
2 participants
@jonjenssen @magnesj