-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor issues #10342
Merged
Merged
Minor issues #10342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toggling state is only supported for objects in an array. For example, this will ensure that faults are toggled without altering the fault result object.
Artifacts are seen in the Property Editor related to obsolete group boxes. This seems to be related to deleteLater().
Co-authored-by: magnesj <[email protected]>
Make sure the previous value of m_showFaultsOutsideFilters_obsolete is propagated into m_applyCellFilters
jonjenssen
reviewed
Jun 6, 2023
ApplicationLibCode/Commands/ToggleCommands/RicToggleItemsFeatureImpl.cpp
Show resolved
Hide resolved
jonjenssen
requested changes
Jun 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8382
Closes #9719
Closes #10011
Closes #10354
Closes #10355