Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WBS: LAS file resolution #6019

Closed
magnesj opened this issue Jun 3, 2020 · 3 comments
Closed

WBS: LAS file resolution #6019

magnesj opened this issue Jun 3, 2020 · 3 comments
Labels
Enhancement An addition that can be observed by the user

Comments

@magnesj
Copy link
Member

magnesj commented Jun 3, 2020

Based on mail from @lasserenli dated 25.05.2020

Resolution not taken from LAS file when LAS is used. Thus, high resolution features in the LAS file not being used. Should always re-sample to smallest increment or be possible to select reference for sampling in reservoir and non-reservoir separately.

@magnesj
Copy link
Member Author

magnesj commented Aug 26, 2020

Related to #5602

@lindkvis
Copy link
Contributor

lindkvis commented Aug 27, 2020

We need to resample no matter what, because if we want to sample from a LAS-point, this has to be combined with some grid-data in the WBS-equations. Now, if the LAS-file has a worse resolution than the grid, we would risk making things worse if we always used the LAS-resolution instead. So I think we have to combine them. Also, we can't really just resample to the same increment as the LAS, as we still might miss the LAS-point. Also, multiple LAS-files may be used and they may have different points.

The most sensible thing to do I think, is to create a combined path of grid intersections and all LAS-points and use this for the sampling. Since grid-indexes are used to get locations currently, we would require a new data structure that can hold also hold LAS-points. Perhaps a vector containing well path point interface-objects that can be either LAS-points or a grid intersections, and for each one of them we make a judgement about how to get the data.

At the same time we should consider getting rid of the OpenMP code in the extractor for almost anything. It is likely too small and too few sub-tasks to provide any benefit.

@magnesj
Copy link
Member Author

magnesj commented Sep 28, 2023

Fixed by #9955

@magnesj magnesj closed this as completed Sep 28, 2023
@github-actions github-actions bot added the PendingRelease Issues is fixed and will be available in next release label Sep 28, 2023
@magnesj magnesj removed the PendingRelease Issues is fixed and will be available in next release label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement An addition that can be observed by the user
Projects
None yet
Development

No branches or pull requests

2 participants