Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments for modern OpenGL widget #11101

Closed
magnesj opened this issue Jan 23, 2024 · 0 comments · Fixed by #11179
Closed

Adjustments for modern OpenGL widget #11101

magnesj opened this issue Jan 23, 2024 · 0 comments · Fixed by #11179
Assignees
Labels
Enhancement An addition that can be observed by the user

Comments

@magnesj
Copy link
Member

magnesj commented Jan 23, 2024

The visualization framework has been updated with support for a modern OpenGL widget. This issue contains comments and issues related to required modifications in ResInsight to be able to use this widget.

Snapshot

Current prototype works on Windows, but does not work on Linux

Reparenting when dock widget changes

  • create a 3D view with docking widgets to the left
  • move dock widgets away from the left edge. This will cause the 3d view to move to the left edge of the application -> crash
  • alternative way to trigger crash is to enter full screen mode
  • fixed by adding QApplication::setAttribute(Qt::AA_ShareOpenGLContexts);

Cleanup after comparison view is deactivated

  • create two views
  • activate Comparison view
  • close project -> crash

Testing related to invalid behaviour during reparent

The following events can be used to detect when parent changes

    if ( e && e->type() == QEvent::ParentAboutToChange )
    {
        deleteFboOpenGLResources();
    }

    if ( e && e->type() == QEvent::ParentChange )
    {
        deleteFboOpenGLResources();
    }

@magnesj magnesj added the Enhancement An addition that can be observed by the user label Jan 23, 2024
@magnesj magnesj added this to the Maintenance 2024 - Sprint 01 milestone Jan 23, 2024
@magnesj magnesj self-assigned this Jan 23, 2024
@github-actions github-actions bot added the PendingRelease Issues is fixed and will be available in next release label Feb 7, 2024
@magnesj magnesj removed the PendingRelease Issues is fixed and will be available in next release label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement An addition that can be observed by the user
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant