Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use empty() instead of checking for size equals 0 #10649

Closed
magnesj opened this issue Sep 25, 2023 · 0 comments · Fixed by #10660
Closed

Use empty() instead of checking for size equals 0 #10649

magnesj opened this issue Sep 25, 2023 · 0 comments · Fixed by #10660
Assignees
@kriben
Labels
System Refactoring or build/test system issues. Code improvments not directly affecting the user.
Milestone
Maintenance 2023 ...

Comments

@magnesj
Copy link
Member

magnesj commented Sep 25, 2023 •
edited
Loading

There are several places in the code where the pattern ...size() > 0 is used. Replace with empty() or isEmpty().

Also make sure this is done in macros in cafPdmObject.h and friends.
@magnesj magnesj added the System Refactoring or build/test system issues. Code improvments not directly affecting the user. label Sep 25, 2023
@magnesj magnesj added this to the Maintenance 2023 - Sprint 9 milestone Sep 25, 2023
kriben added a commit that referenced this issue Sep 27, 2023
@kriben
#10649 Fwk: Use collection.empty() instead of comparing with size
1412ef5
kriben added a commit that referenced this issue Sep 27, 2023
@kriben
#10649 ApplicationLibCode: Use collection.empty() instead of comparin…
ea72a55 
…g with size
@kriben kriben mentioned this issue Sep 27, 2023
Merged
kriben added a commit that referenced this issue Sep 27, 2023
@kriben
#10649 Fwk: Use collection.empty() instead of comparing with size
98796b0
kriben added a commit that referenced this issue Sep 27, 2023
@kriben
#10649 ApplicationLibCode: Use collection.empty() instead of comparin…
959c9d4 
…g with size
@github-actions github-actions bot added the PendingRelease Issues is fixed and will be available in next release label Sep 27, 2023
@magnesj magnesj removed the PendingRelease Issues is fixed and will be available in next release label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kriben kriben

Labels
System Refactoring or build/test system issues. Code improvments not directly affecting the user.
Projects
None yet
Milestone
Maintenance 2023 - Sprint 9
Development

Successfully merging a pull request may close this issue.

10649 empty instead of zero size OPM/ResInsight
2 participants
@kriben @magnesj