Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RifSummaryReaderInterface #10648

Closed
magnesj opened this issue Sep 25, 2023 · 0 comments · Fixed by #10680
Closed

Refactor RifSummaryReaderInterface #10648

magnesj opened this issue Sep 25, 2023 · 0 comments · Fixed by #10680
Assignees
@kriben
Labels
System Refactoring or build/test system issues. Code improvments not directly affecting the user.
Milestone
Deeper 2023 - Spr...

Comments

@magnesj
Copy link
Member

magnesj commented Sep 25, 2023

Return vector instead of passing in as pointer to vector.
@magnesj magnesj added the System Refactoring or build/test system issues. Code improvments not directly affecting the user. label Sep 25, 2023
@magnesj magnesj added this to the Deeper 2023 - Sprint 9 milestone Sep 25, 2023
@magnesj magnesj self-assigned this Sep 25, 2023
@magnesj magnesj mentioned this issue Sep 25, 2023
Merged
@magnesj magnesj assigned kriben and unassigned magnesj Sep 25, 2023
kriben added a commit that referenced this issue Sep 29, 2023
@kriben
#10648 Refactor summary reader: return std::vector<double> instead of…
4fb9fad 
… taking ptr.
@kriben kriben mentioned this issue Sep 29, 2023
Merged
kriben added a commit that referenced this issue Oct 2, 2023
@kriben
#10648 Refactor summary reader: return std::vector<double> instead of…
063a6c5 
… taking ptr.
kriben added a commit that referenced this issue Oct 2, 2023
@kriben
#10648 Refactor summary reader: return std::vector<double> instead of…
5a91f72 
… taking ptr.
kriben added a commit that referenced this issue Oct 2, 2023
@kriben
#10648 Refactor summary reader: return std::vector<double> instead of…
d177491 
… taking ptr.
@github-actions github-actions bot added the PendingRelease Issues is fixed and will be available in next release label Oct 2, 2023
@magnesj magnesj removed the PendingRelease Issues is fixed and will be available in next release label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kriben kriben

Labels
System Refactoring or build/test system issues. Code improvments not directly affecting the user.
Projects
None yet
Milestone
Deeper 2023 - Sprint 9
Development

Successfully merging a pull request may close this issue.

#10648 Refactor summary reader: return std::vector<double> instead of… OPM/ResInsight
2 participants
@kriben @magnesj