Rework crossing question #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7h30n3
force-pushed
the
crossing_question
branch
from
0b9081a
to
22421ac
Compare
7h30n3
force-pushed
the
crossing_question
branch
from
0a463cd
to
e75f7f1
Compare
| @@ -2725,12 +3408,61 @@ | |||
| { | |||
| "osm_tags": { | |||
| "highway": "crossing", | |||
| "crossing": false | |||
| "crossing": [false, "island"], | |||
| "crossing:signal": false | |||
| }, | |||
| "osm_element": "Node" | |||
| } | |||
| ] | |||
| }, | |||
There was a problem hiding this comment.
Clarify why we use "crossing": [false, "island"], in the conditions as a comment. (something like: if the mapper correctly followed the wiki they should have tagged traffic_signals if it was present, so if something else is tagged we implicitly know that crossing:signals=no)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split crossing questions into multiple ones