Advance duration answer #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robbendebiene
force-pushed
the
advance-duration-answer
branch
2 times, most recently
from
91fff62
to
de9c4ad
Compare
Robbendebiene
force-pushed
the
advance-duration-answer
branch
from
de9c4ad
to
70a6b71
Compare
Robbendebiene
force-pushed
the
advance-duration-answer
branch
2 times, most recently
from
85191a2
to
c6c29de
Compare
7h30n3
requested changes
Nov 17, 2023
Robbendebiene
commented
Nov 20, 2023
Robbendebiene
force-pushed
the
advance-duration-answer
branch
from
b2063ba
to
dd8c6c6
Compare
7h30n3
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make the duration input more flexible. The goal is to be able to return the individual duration units separately. They can then be joint and padded in the constructor if needed. This should allow us to finally write the
maxstaytag.