Add questions for railway crossings #195
Conversation
| "answer": { | ||
| "type": "List", | ||
| "input": [ | ||
| { | ||
| "name": "Eine Schranke", | ||
| "image": "", | ||
| "osm_tags": { | ||
| "crossing:barrier": "full" | ||
| } | ||
| }, | ||
| { | ||
| "name": "Eine Schikane", | ||
| "image": "", | ||
| "osm_tags": { | ||
| "crossing:chicane": "yes" | ||
| } | ||
| }, | ||
| { | ||
| "name": "Ein Tor", | ||
| "image": "", | ||
| "osm_tags": { | ||
| "crossing:barrier": "gate" | ||
| } | ||
| }, | ||
| { | ||
| "name": "Eine Kette", | ||
| "image": "", | ||
| "osm_tags": { | ||
| "crossing:barrier": "chain" | ||
| } | ||
| } | ||
| ] | ||
| }, |
There was a problem hiding this comment.
I would remove the "Ein", "Eine" etc. here.
| "osm_tags": { | ||
| "railway": "crossing", | ||
| "crossing:barrier": "yes", | ||
| "crossing:chicane": false | ||
| }, | ||
| "osm_element": ["Node", "OpenWay"] | ||
| }, | ||
| { | ||
| "osm_tags": { | ||
| "railway": "tram_crossing", | ||
| "crossing:barrier": "yes", | ||
| "crossing:chicane": false | ||
| }, | ||
| "osm_element": ["Node", "OpenWay"] | ||
| } | ||
| ] |
There was a problem hiding this comment.
"railway": "crossing" is supposed to be tagged on nodes only so the condition can be tightened.
| "name": "Übergangs-Barriere", | ||
| "text": "Gibt es an diesem Bahnübergang eine Barriere?", | ||
| "description": "Eine Barriere ist alles, was den Übergang für Fußgänger verhindern oder erschweren soll. Dies kann eine Schranke, eine Schikane, eine Kette oder ein Tor sein." | ||
| }, |
There was a problem hiding this comment.
As much as I like having this bool question upfront, I feel like we cannot use this if we combine crossing:barrier and crossing:chicane in one question later on. Because in the case where there is only a chicane we would tag:
"crossing:barrier": "yes"
"crossing:chicane": "yes"
| "question": { | ||
| "name": "Bahnübergangs-Bodenindikatoren", | ||
| "text": "Gibt es Bodenindikatoren an diesem Bahnübergang?", | ||
| "description": "Bodenindikatoren sind Bodenelemente im öffentlichen Raum zur Information, Orientierung, Leitung und Warnung sehbehinderter Menschen. Sie stehen in einem hohen taktilen, visuellen und gegebenenfalls akustischen Kontrast zum angrenzenden Bodenbelag.", | ||
| "image": [ | ||
| "assets/images/questions/tactile_paving_on_kerb.jpg" | ||
| ] | ||
| }, | ||
| "answer": { | ||
| "type": "Bool", | ||
| "input": [ | ||
| { | ||
| "osm_tags": { | ||
| "tactile_paving": "yes" | ||
| } | ||
| }, | ||
| { | ||
| "osm_tags": { | ||
| "tactile_paving": "no" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "conditions": [ | ||
| { | ||
| "osm_tags": { | ||
| "railway": "crossing", | ||
| "tactile_paving": false | ||
| }, | ||
| "osm_element": ["Node", "OpenWay"] | ||
| }, | ||
| { | ||
| "osm_tags": { | ||
| "railway": "tram_crossing", | ||
| "tactile_paving": false | ||
| }, | ||
| "osm_element": ["Node", "OpenWay"] | ||
| } | ||
| ] | ||
| }, |
There was a problem hiding this comment.
This doesn't belong to this PR. If not already covered it should be moved to this PR: https://github.com/OPENER-next/OpenStop/pull/194/files
| "osm_tags": { | ||
| "railway": "tram_crossing", | ||
| "crossing:barrier": "yes", | ||
| "crossing:chicane": false | ||
| }, | ||
| "osm_element": ["Node", "OpenWay"] |
There was a problem hiding this comment.
Do tram crossings with "crossing:barrier" exist in real life?
There was a problem hiding this comment.
At least 2 examples exist: https://overpass-turbo.eu/s/1y8F
| "osm_tags": { | ||
| "railway": "crossing", | ||
| "crossing:barrier": "no", | ||
| "crossing:light": false | ||
| }, | ||
| "osm_element": ["Node", "OpenWay"] | ||
| }, | ||
| { | ||
| "osm_tags": { | ||
| "railway": "tram_crossing", | ||
| "crossing:barrier": "no", | ||
| "crossing:light": false | ||
| }, | ||
| "osm_element": ["Node", "OpenWay"] | ||
| } |
There was a problem hiding this comment.
If we really wan't to ask the same questions for trams and trains, then these conditons can generally be merged:
{
"osm_tags": {
"railway": ["crossing", "tram_crossing"]
"crossing:barrier": "no",
"crossing:light": false
},
"osm_element": "Node"
}
Check other questions as well for this.
| "name": "Eine Schranke", | ||
| "image": "", | ||
| "osm_tags": { | ||
| "crossing:barrier": "full" | ||
| } | ||
| }, | ||
| { | ||
| "name": "Eine Schikane", | ||
| "image": "", | ||
| "osm_tags": { | ||
| "crossing:chicane": "yes" | ||
| } | ||
| }, | ||
| { | ||
| "name": "Ein Tor", | ||
| "image": "", | ||
| "osm_tags": { | ||
| "crossing:barrier": "gate" | ||
| } | ||
| }, | ||
| { | ||
| "name": "Eine Kette", | ||
| "image": "", | ||
| "osm_tags": { | ||
| "crossing:barrier": "chain" | ||
| } | ||
| } | ||
| ] |
There was a problem hiding this comment.
Remove the indefinite article.
| "crossing:barrier": "no", | ||
| "crossing:bell": false | ||
| }, | ||
| "osm_element": "Node" | ||
| }, | ||
| { | ||
| "osm_tags": { | ||
| "railway": "crossing", | ||
| "crossing:barrier": "no", |
There was a problem hiding this comment.
"crossing:barrier": ["no", false]
| "text": "Gibt es ein akustisches Warnsignal bei Durchfahrt der Straßenbahn?", | ||
| "description": "Das Warnsignal ertönt durch ein stationären Signalgeber. Das Klingeln durch Triebfahrzeugführer gehört nicht dazu." | ||
| "name": "Übergangs-Barriere", | ||
| "text": "Gibt es an diesem Bahnübergang eine Barriere?", |
There was a problem hiding this comment.
Always move the import key word at the start of the question, e.g.:
"Gibt es eine Barriere an diesem Bahnübergang?
| "description": "Das Warnsignal ertönt durch ein stationären Signalgeber. Das Klingeln durch Triebfahrzeugführer gehört nicht dazu." | ||
| "name": "Übergangs-Barriere", | ||
| "text": "Gibt es an diesem Bahnübergang eine Barriere?", | ||
| "description": "Eine Barriere ist alles, was den Übergang für Fußgänger verhindern oder erschweren soll. Dies kann eine Schranke, eine Schikane, eine Kette oder ein Tor sein." |
There was a problem hiding this comment.
Replace with: "Eine Barriere an Bahnübergängen dient dazu, die Überquerrung im Fall einer Zugdurchfahrt zu verhindern oder zu erschweren im Sinne der erhöhten Aufmerksamkeit."
| }, | ||
| { | ||
| "question": { | ||
| "name": "Übergangs-Licht", |
There was a problem hiding this comment.
Keep consistent with the naming. Stick with "Bahnübergangs-..."
| { | ||
| "osm_tags": { | ||
| "railway": "crossing", | ||
| "crossing:barrier": "no", | ||
| "crossing:barrier": ["yes", "full", "gate"], |
There was a problem hiding this comment.
Why not half and double_half as value?
Reason: Warning lights can exist for railway crossing barriers
Co-authored-by: René Apitzsch <[email protected]> Co-authored-by: Robbendebiene <[email protected]>
This PR adds questions that will be asked on railway and tram crossings.
The following questions are added:
crossing:barrier=yes/nocrossing:barrier=*crossing:light=yes/nocrossing:whistle=yes/notactile_paving=yes/noThe follwing questions are modified:
crossing:bellThis is the schema after which I modeled the dependencies:
Currently still todo:
crossing:barrier=*-questioncrossing:light=yes/no-questiontactile_paving=yes/no-question(?)crossing:whistle=yes/no-question