Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Group related crossings/simplify if crossing crosses two rails -> OpenStop currently asks once for each rail #258

Open
rugk opened this issue Mar 28, 2024 · 2 comments
Labels
feature request New feature request

Comments

@rugk
Copy link

rugk commented Mar 28, 2024

Idea

If a railway is crossed (aka two lines of railway=tram e.g.), OpenStop asks twice, i.e. once for each rail of the railway (even though they are directly next to each other):
grafik

AFAIK, StreetComplete only asks one quest for such instances. This could be done here, too.

This is a UX issue, because obviously, currently it causes users to answer the whole question catalog in the same way twice, just because the corssing (obviously) crosses two rails. So this normally happens all the time (unless we talk about monorails, but current railways usually use two rails). So this is, IMHO, really a big UX issue as it wastes the time of users and this can definitively discourage users from contributing more – especially if they don't understand/and get why this is done. If one does know OSM insides so much, this behavior is not really easy to explain.

Bug Relation

No response

Implementation

Could not find something in SC implementation that indicates how it is done:
https://github.com/streetcomplete/StreetComplete/blob/902ee5ab8821de8e120306d9bdecdb43c829eac3/app/src/main/java/de/westnordost/streetcomplete/quests/railway_crossing/AddRailwayCrossingBarrier.kt

Maybe only the definition of what it is applicable to, which operates on the way and returns/can return multiple nodes:
https://github.com/streetcomplete/StreetComplete/blob/902ee5ab8821de8e120306d9bdecdb43c829eac3/app/src/main/java/de/westnordost/streetcomplete/quests/railway_crossing/AddRailwayCrossingBarrier.kt#L40-L47

(Tests also not not really explain that – maybe I am mistaken, but I have never seen this behavior of OpenStops in SC.)

Somehow, IMHO, it should look in the same way in vicinity and apply the same tag(s) to the same crossings, if it is sure, these are the same.

Additional Info

No response

@rugk rugk added the feature request New feature request label Mar 28, 2024
@Robbendebiene
Copy link
Member

Sorry for the late reply.

We completely agree. This was actually already on our internal list. We just have to be careful about what to group and how to visualize it, but this is definitely possible.

The condition would be something like "if the crossing nodes are part of the same crossing way" group them.

@rugk
Copy link
Author

rugk commented May 5, 2024

Great! And if advise is needed I guess you can ask @streetcomplete people for implementation details/ideas (I am unsure whether that really pings them, so you may ping one person deliberately or so…)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request
Projects
None yet
Development

No branches or pull requests

2 participants