Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Server] Allow Subject Name Change of Application Certificate in GDS Push scenario #2833

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

romanett
Copy link
Contributor

@romanett romanett commented Nov 3, 2024

Proposed changes

Extend CertificateIdentifier to allow Certificate to be found by applicationUri in addition to the subject name.
This allows an Administator to perform a certificate update and changing the subject name specified in the application certificate during the process

Related Issues

  • Fixes #

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 77.14286% with 8 lines in your changes missing coverage. Please review.

Project coverage is 55.28%. Comparing base (ce33d63) to head (ce0b808).

Files with missing lines Patch % Lines
...ore/Security/Certificates/CertificateIdentifier.cs 58.33% 3 Missing and 2 partials ⚠️
...raries/Opc.Ua.Configuration/ApplicationInstance.cs 83.33% 1 Missing ⚠️
...a.Server/Configuration/ConfigurationNodeManager.cs 88.88% 0 Missing and 1 partial ⚠️
...Security/Certificates/DirectoryCertificateStore.cs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2833      +/-   ##
==========================================
- Coverage   55.70%   55.28%   -0.42%     
==========================================
  Files         352      352              
  Lines       67332    67345      +13     
  Branches    13806    13813       +7     
==========================================
- Hits        37506    37233     -273     
- Misses      25792    26029     +237     
- Partials     4034     4083      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant