Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Server] ValidateRolePermissions of MonitoredItems based of the saved user identity to allow validation when no session is present #2832

Open
wants to merge 3 commits into
base: develop/main374
Choose a base branch
from

Conversation

romanett
Copy link
Contributor

@romanett romanett commented Nov 1, 2024

Proposed changes

Extend IMonitoredItem Interface to allow the access to the savedUserIdentity of the owning Subscription.

This allows the MonitoredNode to validate the RolePermissions of the owning user of the MI to decide if reading the value /event is allowed.

Related Issues

Types of changes

  • [] Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • x ] Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

@romanett romanett self-assigned this Nov 3, 2024
@romanett romanett requested a review from mregen November 3, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant