Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidateRolePermissions for MIs montioring the Value of a Node #2809

Open
wants to merge 2 commits into
base: develop/main374
Choose a base branch
from

Conversation

romanett
Copy link
Contributor

Proposed changes

Adds a validation of the RolePermissions for MonitoredItems monitoring the Value of a Node.

The validation is already in place for event monitored items and is also added for dataChangeMonitoredItems with this PR.

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

After investigation I came to the following conclusion:

creating a MI is correctly validating the role permissions
however changing the user identity after the MI exists you are still allowed to receive data changes.
Test Setup:

Reference Server
Node: ns=2 nodeId=AccessRights_RolePermissions_ConfigureAdmin
node creation:
image

Client 1: Configure Admin (sysadmin) ->sucessfully monitor node
Client 2: Anonymous -> cant create MI
Client 1: -> change user identity to anonymous -> still monitors node
Client 2: -> write node
Client 1-> receives Data change even though it should not be able to

@romanett romanett added the bug A bug was identified and should be fixed. label Oct 23, 2024
@romanett romanett added this to the 1.5.374 Oktober Update milestone Oct 23, 2024
@romanett romanett self-assigned this Oct 23, 2024
@romanett romanett linked an issue Oct 23, 2024 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug was identified and should be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session is not provided by "ClearChangeMasks" when a change is notified
1 participant