Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatView: Fix zero() #727

Merged
merged 1 commit into from
Sep 4, 2024
Merged

DatView: Fix zero() #727

merged 1 commit into from
Sep 4, 2024

Conversation

pbrubeck
Copy link
Collaborator

Fix DatView.zero() by overriding DatView._data to return the parent slice.

connorjward
connorjward previously requested changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test and make sure this doesn't break Firedrake CI.

@dham dham dismissed connorjward’s stale review September 4, 2024 15:31

added in Firedrake

@dham dham merged commit b84b770 into master Sep 4, 2024
4 checks passed
@dham dham deleted the pbrubeck/fix/zero-dat-view branch September 4, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- left review comments

@dham dham dham approved these changes

@connorjward connorjward connorjward left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pbrubeck @dham @wence- @connorjward