composed map: add permute to kwarg #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjward
previously approved these changes
Jun 14, 2024
ksagiyam
force-pushed
the
ksagiyam/fix_composed_map
branch
from
acae6c5
to
b9c031a
Compare
|
Actually, a pyop2 test failed, which suggested a better fix. Could you have a look again? |
|
Rerunning Firedrake CI. |
connorjward
requested changes
Jun 14, 2024
Co-authored-by: Connor Ward <[email protected]>
Co-authored-by: Connor Ward <[email protected]>
|
Indeed. Rerunning Firedrake CI. |
connorjward
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firedrakeproject/firedrake#3634
I found this bug when using the submesh branch with BCs on vector components. It is hard to test with our current usage of ComposedMap in Firedrake. I wonder this can just go in.