Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] 중복되는 코드 수정 #277

Closed
1 task
youz2me opened this issue Aug 4, 2024 · 0 comments · Fixed by #295
Closed
1 task

[refactor] 중복되는 코드 수정 #277

youz2me opened this issue Aug 4, 2024 · 0 comments · Fixed by #295
Assignees
@youz2me
Labels
♻️ refactor 기존 코드를 리팩토링하거나 수정하는 등 사용 (생산적인 경우) 💚 YouJin 저댄고?저댄고?저댄고?저댄고?저댄고?

Comments

@youz2me
Copy link
Member

youz2me commented Aug 4, 2024 •
edited
Loading

작업할 브랜치

  • refactor/#277-deduplication 브랜치에서 작업합니다.

✔️ To-Do

  • 중복되는 코드 병합 또는 삭제
@youz2me youz2me added ♻️ refactor 기존 코드를 리팩토링하거나 수정하는 등 사용 (생산적인 경우) 💚 YouJin 저댄고?저댄고?저댄고?저댄고?저댄고? labels Aug 4, 2024
@youz2me youz2me self-assigned this Aug 4, 2024
youz2me added a commit that referenced this issue Aug 8, 2024
@youz2me
refactor/#277 MeetingService 네이밍 리팩토링
fcbc682
youz2me added a commit that referenced this issue Aug 8, 2024
@youz2me
refactor/#277 JoinButtonView 텍스트 설정 함수 대신 생성자로 초기화 가능하도록 변경
994294c
youz2me added a commit that referenced this issue Aug 8, 2024
@youz2me
refactor/#277 생명주기에 맞게 함수 위치 변경
4de1141
youz2me added a commit that referenced this issue Aug 8, 2024
@youz2me
refactor/#277 serviceType serviceProtocol로 네이밍 변경
3a0008f
youz2me added a commit that referenced this issue Aug 8, 2024
@youz2me
refactor/#277 생명 주기대로 순서 리팩토링 및 didtapped 함수 이름 didtap으로 변경
eeed63d
youz2me added a commit that referenced this issue Aug 8, 2024
@youz2me
refactor/#277 변수 속성 맞게 재정렬, viewController에서 rootView와 viewModel의 네이밍…
b5219d6 
… 통일, extension 함수 분리
youz2me added a commit that referenced this issue Aug 8, 2024
@youz2me
refactor/#277 모임 생성 binding 코드 잘못된 로직 수정
f14a61d
youz2me added a commit that referenced this issue Aug 9, 2024
@youz2me
refactor/#277 초대 코드 입력 화면 리팩토링
8ac0b5d
youz2me added a commit that referenced this issue Aug 9, 2024
@youz2me
refactor/#277 모임 생성 성공 뷰 네이밍 변경 및 사용하지 않는 파일 삭제
3578219
youz2me added a commit that referenced this issue Aug 15, 2024
@youz2me
refactor/#277 PagePromise 리팩토링
7d5b331
youz2me added a commit that referenced this issue Aug 15, 2024
@youz2me
refactor/#277 리팩토링 내용 임시 저장 커밋
d9ad916
@youz2me youz2me mentioned this issue Aug 15, 2024
Merged
@youz2me youz2me linked a pull request Aug 15, 2024 that will close this issue
[refactor] 모임 생성, 약속 상세 전반적인 리팩토링 #295
Merged
youz2me added a commit that referenced this issue Aug 15, 2024
@youz2me
refactor/#277 코드리뷰 반영
981586d
youz2me added a commit that referenced this issue Aug 16, 2024
@youz2me
Merge pull request #295 from OMZigak/refactor/#277-deduplication
060a977 
[refactor] 모임 생성, 약속 상세 전반적인 리팩토링
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youz2me youz2me

Labels
♻️ refactor 기존 코드를 리팩토링하거나 수정하는 등 사용 (생산적인 경우) 💚 YouJin 저댄고?저댄고?저댄고?저댄고?저댄고?
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[refactor] 모임 생성, 약속 상세 전반적인 리팩토링 OMZigak/KKUYOS
1 participant
@youz2me