Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] 전체적인 컨벤션 조정 #188

Closed
4 tasks done
youz2me opened this issue Jul 16, 2024 · 0 comments · Fixed by #189
Closed
4 tasks done

[refactor] 전체적인 컨벤션 조정 #188

youz2me opened this issue Jul 16, 2024 · 0 comments · Fixed by #189
Assignees
@youz2me
Labels
✨ feat 기능 구현시 사용 ♻️ refactor 기존 코드를 리팩토링하거나 수정하는 등 사용 (생산적인 경우) 💚 YouJin 저댄고?저댄고?저댄고?저댄고?저댄고?

Comments

@youz2me
Copy link
Member

youz2me commented Jul 16, 2024 •
edited
Loading

작업할 브랜치

  • refactor/#188-convention 브랜치에서 작업합니다.

✔️ To-Do

  • override 제외한 함수는 extension으로 분리
  • 전체적인 View 및 로직 점검
  • 개행 체크하기
  • 네이밍 체크하기

기타 이야기해볼 점

  • 일단 제가 작업한 부분 제외한 코드는 건드리지 않는게 맞다고 생각해서 이번 PR은 제 작업 공간 안에서만 진행했습니다. 논의해볼 사항이 있다면 알려주세요!
@youz2me youz2me added ✨ feat 기능 구현시 사용 ♻️ refactor 기존 코드를 리팩토링하거나 수정하는 등 사용 (생산적인 경우) 💚 YouJin 저댄고?저댄고?저댄고?저댄고?저댄고? labels Jul 16, 2024
@youz2me youz2me self-assigned this Jul 16, 2024
youz2me added a commit that referenced this issue Jul 16, 2024
@youz2me
refactor/#188 override 함수 제외하고 extension으로 분리
2162f43
youz2me added a commit that referenced this issue Jul 16, 2024
@youz2me
fix/#188 build phase duplicate 오류 해결
80092ae
youz2me added a commit that referenced this issue Jul 16, 2024
@youz2me
add/#188 앱 아이콘 추가
a09bb65
youz2me added a commit that referenced this issue Jul 16, 2024
@youz2me
refactor/#188 주석 추가
6a33b8b
@youz2me youz2me mentioned this issue Jul 16, 2024
Merged
@youz2me youz2me linked a pull request Jul 16, 2024 that will close this issue
[refactor] 전체적인 컨벤션 조정 #189
Merged
youz2me added a commit that referenced this issue Jul 16, 2024
@youz2me
fix/#188 오류 해결
34049a5
youz2me added a commit that referenced this issue Jul 16, 2024
@youz2me
Merge pull request #189 from OMZigak/refactor/#188-convention
917f8bb 
[refactor] 전체적인 컨벤션 조정
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youz2me youz2me

Labels
✨ feat 기능 구현시 사용 ♻️ refactor 기존 코드를 리팩토링하거나 수정하는 등 사용 (생산적인 경우) 💚 YouJin 저댄고?저댄고?저댄고?저댄고?저댄고?
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[refactor] 전체적인 컨벤션 조정 OMZigak/KKUYOS
1 participant
@youz2me