Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnint 64to32 6186 v23.2 #11705

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186

Describe changes:

  • fix -Wshorten-64-to-32 warnings for some files : output, stream

Some commits of #9840
#11580 next batch
#11700 with code review taken into account

Still to do afterwards :

  • detect
  • util

Victor, I let you review the stream stuff ;-)

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 85.93750% with 9 lines in your changes missing coverage. Please review.

Project coverage is 82.63%. Comparing base (685baa9) to head (9ca2f67).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11705      +/-   ##
==========================================
- Coverage   82.63%   82.63%   -0.01%     
==========================================
  Files         919      919              
  Lines      248925   248913      -12     
==========================================
- Hits       205703   205684      -19     
- Misses      43222    43229       +7     
Flag Coverage Δ
fuzzcorpus 60.88% <78.12%> (+<0.01%) ⬆️
livemode 18.75% <7.81%> (+0.03%) ⬆️
pcap 44.10% <54.68%> (-0.05%) ⬇️
suricata-verify 61.85% <82.81%> (-0.03%) ⬇️
unittests 59.01% <14.06%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

ERROR:

ERROR: QA failed on SURI_TLPR1_alerts_cmp.

Pipeline 22390

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 22430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants