Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

取消 CSS 的内联 #313

Open
Enter-tainer opened this issue Jun 23, 2020 · 6 comments
Open

取消 CSS 的内联 #313

Enter-tainer opened this issue Jun 23, 2020 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed performance There is a problem or suggestion about performance

Comments

@Enter-tainer
Copy link
Member

目前，在build生成的html中，css类内联在head里面，每一个html都有一份相同的内联格式，这些css无法被缓存，可能存在性能损失。

因此希望能把css单独拿出来。
@Enter-tainer Enter-tainer added enhancement New feature or request help wanted Extra attention is needed performance There is a problem or suggestion about performance labels Jun 23, 2020
@Enter-tainer
Copy link
Member Author

https://cssinjs.org/faq/?v=v10.3.0

@hirohe
Copy link

hirohe commented Sep 14, 2020

mui/material-ui#20861

StylesProvider的disableGeneration可以决定是否生成样式

但是这样还需要额外地导入material-ui的样式

@hirohe hirohe mentioned this issue Sep 29, 2020
Closed
@ghost
Copy link

ghost commented Aug 27, 2021

any update ?

@Enter-tainer
Copy link
Member Author

pr一直没有合并的原因是该pr并没有完全解决问题，即使加上了那个插件，还有相当一部分css是非内联的

@SkyeYoung
Copy link
Member

@stfenjobs 在尝试升级到 MUI v5，可能会解决本问题。

@ghost
Copy link

ghost commented Aug 27, 2021

@Enter-tainer @SkyeYoung thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed performance There is a problem or suggestion about performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hirohe @Enter-tainer @SkyeYoung