Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Regression handling RGB in XC modality #4382

Open
fedorov opened this issue Sep 18, 2024 · 3 comments
Open

[Bug] Regression handling RGB in XC modality #4382

fedorov opened this issue Sep 18, 2024 · 3 comments
Labels
Awaiting Reproduction Can we reproduce the reported bug? IDC:priority Items that the Imaging Data Commons wants to help sponsor

Comments

@fedorov
Copy link
Member

fedorov commented Sep 18, 2024

Describe the Bug

This sample is no longer rendered correctly: https://viewer.imaging.datacommons.cancer.gov/v3/viewer/?StudyInstanceUIDs=1.3.6.1.4.1.5962.1.2.0.1677425356.1733

image

For comparison, see how it used to work here: #3354 (comment):

image

To download the files in that study (note - it is ~233GB!), assuming you have python and pip on your system, do the following:

pip install --upgrade idc-index
idc download 1.3.6.1.4.1.5962.1.2.0.1677425356.1733

Steps to Reproduce

Load the sample study referenced in the above into the viewer.

The current behavior

First series shows grayscale with multiple slices arranged in a mosaic. Second does not load at all.

The expected behavior

Both should show up in color as used to work in the past given the screenshot in #3354 (comment)

OS

macOS

Node version

n/a

Browser

Chrome

@fedorov fedorov added IDC:priority Items that the Imaging Data Commons wants to help sponsor Awaiting Reproduction Can we reproduce the reported bug? labels Sep 18, 2024
@sedghi
Copy link
Member

sedghi commented Sep 18, 2024

For instance, if I want to debug this specific study without downloading it, how can I do that in my local OHIF since you said the DICOMweb server is public?

CC @igoroctaviano

@fedorov
Copy link
Member Author

fedorov commented Sep 18, 2024

@sedghi I am not an OHIF developer, so I cannot answer how to do it in OHIF configuration (@igoroctaviano can), but IDC public DICOMweb endpoint is this: https://proxy.imaging.datacommons.cancer.gov/current/viewer-only-no-downloads-see-tinyurl-dot-com-slash-3j3d9jyp/dicomWeb (documented in https://learn.canceridc.dev/portal/proxy-policy). Note that the "no downloads" wording in the URL is legacy, and we do not restrict that DICOMweb endpoint for downloads - as discussed in the link above.

@fedorov
Copy link
Member Author

fedorov commented Sep 26, 2024

DICOM PlanarConfiguration will indicate whether color image is ordered as RGBRGB or RRGGBB. Need to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Reproduction Can we reproduce the reported bug? IDC:priority Items that the Imaging Data Commons wants to help sponsor
Projects
None yet
Development

No branches or pull requests

2 participants