Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test loading/inference on all supported Python and TF versions #83

Closed
mikegerber opened this issue Feb 15, 2023 · 7 comments
Closed

Test loading/inference on all supported Python and TF versions #83

mikegerber opened this issue Feb 15, 2023 · 7 comments
Assignees
Labels
dependencies Pull requests that update a dependency file maintenance

Comments

@mikegerber
Copy link
Collaborator

Learning from qurator-spk/eynollah#87/qurator-spk/eynollah#87 I think we should test loading/test inference on all supported Python and TF versions. The worst that can happen is to learn what isn't working.

I'd do this after #61.

@mikegerber mikegerber self-assigned this Feb 15, 2023
@mikegerber mikegerber added dependencies Pull requests that update a dependency file maintenance labels Feb 15, 2023
@mikegerber
Copy link
Collaborator Author

The best that can happen: Have an understanding of how to save a model so it can be loaded under all (supported) circumstances.

@bertsky
Copy link
Contributor

bertsky commented Feb 15, 2023

Indeed. And to make it work better, as a precaution, we should try to get Calamari to support SavedModel format. In fact, the problem has already surfaced.

@mikegerber
Copy link
Collaborator Author

@bertsky I agree (tentatively, as I have not yet made myself familiar with it, but it sure looks like the best solution)

@mikegerber
Copy link
Collaborator Author

mikegerber commented Feb 23, 2023

We already do this (the testing of Python 3.6 to 3.10), I just forgot about it :-)

  • Python 3.11 (Test on Python 3.11 #77) needs to be reviewed
  • [ ] Why is the CircleCI result not accessible/private? (→ Moved to Review tests #72)
  • [ ] Consider scheduled tests (TensorFlow dependency tends to break, and I only notice when something new is pushed) (Already in Review tests #72)

@mikegerber
Copy link
Collaborator Author

Python 3.11 does not work currently and I don't think I'll investigate further until we can update to Calamari 2. (→ #77)

@mikegerber
Copy link
Collaborator Author

mikegerber commented Mar 14, 2023

(Moved comment to #72)

@mikegerber
Copy link
Collaborator Author

Closing as this is already done and for the other stuff we have #72.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

No branches or pull requests

2 participants