Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build (and Test) Docker container according to specs #36

Open
mikegerber opened this issue Feb 10, 2020 · 6 comments
Open

Build (and Test) Docker container according to specs #36

mikegerber opened this issue Feb 10, 2020 · 6 comments

Comments

@mikegerber
Copy link
Collaborator

No description provided.

@mikegerber mikegerber added the question Further information is requested label Feb 10, 2020
@mikegerber mikegerber self-assigned this Feb 10, 2020
@mikegerber
Copy link
Collaborator Author

Probably going to close/remove this. We already have two Docker builds (ocrd_all and ocrd-galley) and should concentrate on that.

Pending review of things that need to be removed.

@mikegerber mikegerber added maintenance and removed question Further information is requested labels Feb 17, 2023
@mikegerber
Copy link
Collaborator Author

(And pending communication with @kba, but I doubt he will see this differently)

@bertsky
Copy link
Contributor

bertsky commented Feb 17, 2023

I disagree. ocrd_all will soon switch from fat container to slim container, meaning that it will delegate to the images that its sub-modules provide themselves. These module images must then abide by the OCR-D convention (which will contain a network entrypoint) and be available in a public container registry like Dockerhub (and ideally backed by CI). So disabling Docker build is the wrong direction IMO.

@kba
Copy link
Member

kba commented Feb 19, 2023

(And pending communication with @kba, but I doubt he will see this differently)

I agree with @bertsky here, we would be disabling it now only to reenable it in a few weeks when we start providing slim containers (one Docker container per project with workers listening on queue).

@mikegerber
Copy link
Collaborator Author

Ah. Then I'll wait/switch to building a container according to OCR-D convention.

Is there documentation about the OCR-D convention?

@kba
Copy link
Member

kba commented Feb 20, 2023

Ah. Then I'll wait/switch to building a container according to OCR-D convention.

Is there documentation about the OCR-D convention?

Not for the new slim containers yet, since we require the Web API reference implementation in core to be ready which it is not but will be soon.

Once that's in place, we will update our docker documentation

@mikegerber mikegerber changed the title Check if the Docker build is useful as it is Build (and Test) Docker container according to specs Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants