Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] cms_info: add url field + ease overrides #129

Merged
merged 1 commit into from
Jul 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 27 additions & 17 deletions cms_info/models/cms_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,35 +32,45 @@ def cms_delete_url_base(self):
def cms_after_delete_url(self):
return "/"

url = fields.Char(
string="URL",
compute="_compute_cms_url",
)
cms_edit_url = fields.Char(
string="CMS edit URL",
compute="_compute_cms_edit_url",
compute="_compute_cms_url",
)

cms_delete_url = fields.Char(
string="CMS delete URL",
compute="_compute_cms_delete_url",
compute="_compute_cms_url",
)

cms_delete_confirm_url = fields.Char(
string="CMS delete confirm URL",
compute="_compute_cms_delete_url",
compute="_compute_cms_url",
)

def _compute_cms_edit_url(self):
base_url = self.cms_edit_url_base
for item in self:
item.cms_edit_url = "{}/{}".format(base_url, item.id)
def _compute_cms_url(self):
for rec in self:
rec.url = rec._get_cms_url()
rec.cms_edit_url = rec._get_cms_edit_url()
rec.update(rec._get_cms_delete_urls())

def _get_cms_url(self):
# TODO: add glue module for website
# TODO: should be empty by default?
base_view_url = self._cms_make_url("view")
return f"{base_view_url}/{self.id}"

def _compute_cms_delete_url(self):
def _get_cms_edit_url(self):
base_edit_url = self.cms_edit_url_base
return f"{base_edit_url}/{self.id}"

def _get_cms_delete_urls(self):
base_url = self.cms_delete_url_base
for item in self:
item.update(
{
"cms_delete_url": "{}/{}".format(base_url, item.id),
"cms_delete_confirm_url": "{}/{}/confirm".format(base_url, item.id),
}
)
return {
"cms_delete_url": "{}/{}".format(base_url, self.id),
"cms_delete_confirm_url": "{}/{}/confirm".format(base_url, self.id),
}

def cms_is_owner(self, uid=None):
self.ensure_one()
Expand Down
6 changes: 6 additions & 0 deletions cms_info/tests/test_info_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@ def test_create_url(self):
def test_search_url(self):
self.assertEqual(self.record.cms_search_url, "/cms/search/fake.model")

def test_view_url(self):
self.assertEqual(
self.record.url,
"/cms/view/fake.model/%s" % self.record.id,
)

def test_edit_url(self):
self.assertEqual(
self.record.cms_edit_url,
Expand Down