Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEA: Shell interface reading config from a config file. #30

Open
nhomar opened this issue Oct 15, 2018 · 7 comments
Open

IDEA: Shell interface reading config from a config file. #30

nhomar opened this issue Oct 15, 2018 · 7 comments
Assignees

Comments

@nhomar
Copy link
Member

nhomar commented Oct 15, 2018

IDEA

What about including click create sort kind of command line options (auto generated in an abstract way) to be able to have sort kind of CLI a'la erppeek?

Regards.

@sebalix
Copy link
Collaborator

sebalix commented Oct 15, 2018

Hi @nhomar ,
It's a feature which has been asked a long time ago, and I even started a branch last year about that: https://github.com/sebalix/odoorpc/tree/interactive-shell
But I never take the time to continue this development further. It precisely lacks of a creation of an ODOO session object directly from a config file. Still on my TODO list, but if someone wants to do it, no problem :)

@nhomar
Copy link
Member Author

nhomar commented Oct 15, 2018

@sebalix

I'll take care from here on a copy of the work you started.

In few days you will receive a PR.

@nhomar
Copy link
Member Author

nhomar commented Oct 15, 2018

Setting TODO:

  • Create basic wrapper on under folder cli, using click.
  • Design a solution to use a config file in a local environment (.odoorpc file under .local as standard maybe).
  • Make it auto-completion aware.
  • Review the requirements.txt.
  • Make it pip sustainable and create unit test.
  • Improve PR text to allow a proper merge.
  • Improve the documentation.

@nhomar nhomar self-assigned this Oct 15, 2018
@sebalix
Copy link
Collaborator

sebalix commented Oct 16, 2018

Great! Thank you @nhomar
The work started is not big, feel free to implement this in another way (in a new Python package if you want).

@nhomar
Copy link
Member Author

nhomar commented Oct 16, 2018

Hello @sebalix

Ok, I will consider it, but I think the more obvious way is here and you have already all the package being managed beautifully then I can follow your quality strategy instead reinvent my own ;-)

But I will check and let you know.

@sebalix
Copy link
Collaborator

sebalix commented Oct 16, 2018

I misunderstand you, I thought you wanted to create a sort of second package inside this repo. Nevermind, of course a PR against this repository is the way to go.

@pedrobaeza
Copy link
Member

I think this is already handled with https://github.com/acsone/click-odoo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants