[14.0][IMP] account_statement_import_camt54 add the parameter to the view

[ecino]

The transfer_line parameter wasn't added to the view although it was defined in the model.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[ecino]

@alexis-via Willing to review this small PR?

[ecino]

@OCA/banking-maintainers Anyone willing to review?

[StefanRijnhart]

I'm really disappointed that this feature was added on the camt54 level rather than generically. This aspect is missing from the field's help text. It suspiciously uses amount == 0 rather than res.currency's is_zero and the feature was snuck in in a module migration without any mention in the PR description rather than in its own PR.

Are you using this feature? Otherwise I'd say maybe keep it hidden until it's improved.

[ecino]

Yes we think this feature is useful and are using it. I made a few changes based on your comments. I'm not convinced the feature would be useful at the generic level though.

[StefanRijnhart]

Thanks for addressing my rant so gracefully! Please use the prefix [IMP] account_statement_import_camt54: in all commits (I would squash these together myself).

[ecino]

You're welcome 😉
I reworded the commits.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.