Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move examples from OpenAPI-Specification repository #102

Merged

Conversation

Bellangelo
Copy link
Member

Partially addresses: OAI/OpenAPI-Specification#3854

  1. Copied/Pasted all the examples.
  2. Added tests for the examples.
  3. Fixed tictactoe example be9af73 as it wasn't passing the tests.
  4. Moved yaml-to-json script.
  5. Generated a json file for the pre-existing tictactoe example.
  6. Added workflows for converting the YAML files and running their tests.

Copy link
Collaborator

@miqui miqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my review is in WIP @Bellangelo , @handrews - lots of files in a single PR.

@miqui
Copy link
Collaborator

miqui commented Jun 3, 2024

Should be able to approve this soon unless @handrews , @SensibleWood , or any other user posts a concern.

Copy link
Member

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good- thanks for working out the right dependencies in package.json instead of copying everything from the spec repo!

apiKey: []
app2AppOauth:
- board:read
- apiKey: []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be defaultApiKey to match the component name under #/components/securitySchemes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants