Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align FailureAction.Retry-After with the Retry-After response HTTP header #122

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Align FailureAction.Retry-After with the Retry-After response HTTP header #122

merged 1 commit into from
Jan 31, 2024

Conversation

frankkilcommins
Copy link
Collaborator

Fixes #100

@frankkilcommins frankkilcommins added the implementor-draft In scope for first version label Jan 26, 2024
@frankkilcommins frankkilcommins mentioned this pull request Jan 30, 2024
Closed
ndenny
ndenny approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@ndenny ndenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, milliseconds -> seconds, looks good

@frankkilcommins frankkilcommins merged commit d55e139 into main Jan 31, 2024
2 checks passed
@frankkilcommins frankkilcommins deleted the frankkilcommins/issue100 branch July 31, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndenny ndenny ndenny approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

Assignees
No one assigned
Labels
implementor-draft In scope for first version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align FailureAction.Retry-After with HTTP Retry-After - seconds rather than milliseconds
2 participants
@frankkilcommins @ndenny