Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clock fault condition #9

Open
bschulz1701 opened this issue Dec 6, 2018 · 1 comment
Open

Fix Clock fault condition #9

bschulz1701 opened this issue Dec 6, 2018 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@bschulz1701
Copy link
Contributor

Currently when no clock battery is installed, the message printed is

Clock:  PASS, BAD TIME
 FAIL

This triggers both an OBError and a TimeError, fix such that if the clock does not increment (which will correctly cause an OBError), then this invalidates a TimeError and the resurned result should simply be

Clock: FAIL

Triggering just an OBError, not a TimeError since this (while technically correct) is confusing and can give the illusion from light states that the clock is not the problem

@bschulz1701 bschulz1701 added the bug Something isn't working label Dec 6, 2018
@bschulz1701 bschulz1701 self-assigned this Dec 6, 2018
@awickert
Copy link
Member

awickert commented Mar 4, 2021

Just tested now after removing the CR1220 battery. Output:

Timestamp = 2000/01/01 00:00:00
I2C:  Fail
   Fail At: 42
Clock:  PASS, BAD TIME
SD: PASS
Bat = 2.77V	0.00%
Temp = 23.66C
Pressure = 997.17 mBar
RH = 20.30%

The I2C fail is for Project Haar; not related to the problem here, I think.

@awickert awickert added this to the v0.2.0 milestone Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants