Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style prop isn't applied in v3 #75

Open
markphilpot opened this issue Oct 24, 2022 · 10 comments
Open

style prop isn't applied in v3 #75

markphilpot opened this issue Oct 24, 2022 · 10 comments

Comments

@markphilpot
Copy link

We needed to jump to v3 to take control over the style injection into shadow roots, but ran into this issue:

The style override prop is never applied to the ScrollContainer component

CleanShot 2022-10-24 at 16 44 10@2x

@Norserium
Copy link
Owner

@markphilpot, fixed in 3.0.1-alpha. Try it.

@Norserium
Copy link
Owner

@markphilpot, any news?

@danijun96
Copy link

danijun96 commented Nov 25, 2022

@Norserium I was trying to use onEndScroll prop but it doesn't exist as well I think other props are missing too. change to older version 2.2.0 to make it work

@Norserium
Copy link
Owner

@danijun96, it's fixed in 3.0.2-alpha. Check this out.

@danijun96
Copy link

@danijun96, it's fixed in 3.0.2-alpha. Check this out.

now it works, but I will stick to 2.2.0 as this is alpha version and I am using this lib in prod. I also faced some other issue

  1. when I add css property scroll-behavior: smooth; to the container the drag stopped working the reason to add 'scroll-behavior: smooth;' is because I created two buttons next and prev to be able to move the scrollBar also smoothly.
    Also thank you for the great work!

@Norserium
Copy link
Owner

now it works, but I will stick to 2.2.0 as this is alpha version and I am using this lib in prod.

No problem, that's why it's called alpha.

is because I created two buttons next and prev to be able to move the scrollBar also smoothly.

Did you try to set behavior in scrollTo options instead? The example.

@danijun96
Copy link

Did you try to set behavior in scrollTo options instead? The example.

Yes something similar came to my mind as well but with scrollBy it also has this option for smooth behavior. But I faced a problem I will describe it below.
In my app when I hit the end of the scroll an API request is being called to get next elements, i am using onEndScroll to fetch this event and also have marked the last item to check when it's in view, so the problem was when the call was made i got rendered too many items instead of only what was needed, for example if 50 elements had to be rendered i got 910 rendered, not sure why this happens and it happens when moving the scroll bar with button. with dragging is okay. I am not sure if the problem is on my side, but with 2.2.0 works okay.

@Norserium
Copy link
Owner

Let me make this clear, you update to 3.0.2-alpha and get this misbehavior immediately?

Did you include the library styles?

import 'react-indiana-drag-scroll/dist/style.css';

@danijun96
Copy link

Let me make this clear, you update to 3.0.2-alpha and get this misbehavior immediately?

Did you include the library styles?

import 'react-indiana-drag-scroll/dist/style.css';

Yes I did all that.

@Norserium
Copy link
Owner

Norserium commented Nov 26, 2022

@danijun96, it's strange, but without debugging this specific case I couldn't help you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants