Safer withargs #97
Closed
Safer withargs #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes NorfairKing#91 by avoiding a call to `withArgs` if the argument list is already empty. `withArgs` can crash in a concurrent environment (see GHC BUG https://gitlab.haskell.org/ghc/ghc/-/issues/18261), hence we reduce the chance of this happening by not calling it when the list of arguments is already in the required state (e.g. empty).
|
Oh that sounds great! |
|
About to merge once this passes: I renamed the function to |
|
Merged manually and released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #91 by avoiding
a call to
withArgsif the argument list is already empty.withArgscan crash in a concurrent environment (see GHC BUGhttps://gitlab.haskell.org/ghc/ghc/-/issues/18261), hence we reduce the
chance of this happening by not calling it when the list of arguments is
already in the required state (e.g. empty).