Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to load local models, added early stopping, remove vocab check, fixed GPTJ model conversion #38

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mallorbc
Copy link
Contributor

@mallorbc mallorbc commented Apr 7, 2023

This PR is built on top of the pip package PR. Merge that PR first and if that PR changes those changes will need to be merged first.

In this PR I added the ability to load a model from a local path.

I also added early stopping allowing one to stop based on some token. Related to this, I changed the default behavior of waiting for the subprocess. Using these two together, I was able to achieve a large speedup for my desired task.

I removed the check for vocab size. When finetuning the vocab size can change, especially for GPTJ. Figuring out this was causing issues was a source of headache and is needed for fientuned models.

I also made it so that instead of using the Huggingface vocab and config, if we give a local path we will use those files in that folder, again common for finetuning.

This repo was the only one I could get working for GPTJ. Other repos are using a different GGML format. However, those other repos keep the model in memory with pybindings, such as pyllamacpp. If that feature was added, this repo would be great as suggested #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants