Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization #3

Open
dodekaphilist opened this issue May 13, 2018 · 28 comments
Open

Internationalization #3

dodekaphilist opened this issue May 13, 2018 · 28 comments

Comments

@dodekaphilist
Copy link

I'd like to translate the programm into my language for a better integration into the system.
Could you provide support for that?

@NiyaShy NiyaShy self-assigned this May 15, 2018
@NiyaShy
Copy link
Owner

NiyaShy commented May 15, 2018

Uh, well... It probably could be done, but in the current state all messages are inside the code. So it would require some re-writing and i'd have to dig into how to include external files (think that would be the easiest way to include new languages).

@NiyaShy NiyaShy added Planned to be implemented This feature will probably be added at some point in the future ;) and removed Feature request labels Jan 27, 2019
@NiyaShy NiyaShy mentioned this issue Mar 24, 2019
@Friday-The13-rus
Copy link

@NiyaShy could you please look at the pull request and, if all is OK from your point of view, merge it into your repository?

@NiyaShy NiyaShy added Implemented/fixed in testing Feature/fix is already in the testing code but not yet released as a new version and removed Planned to be implemented This feature will probably be added at some point in the future ;) labels Mar 27, 2019
@NiyaShy
Copy link
Owner

NiyaShy commented Apr 13, 2019

Thanks to the code @RogerUP13 provided there is now a working translation/language switcher system in the code which will be released with version 1.3.0.0.
Wanna help with a new translation? Download the English string file (right click -> save target), open it in Notepad (or your favourite text editor) and edit the strings in the <data> elements that start at line 120.
Save the file as Strings.<language code>.resx (you can find the 2-letter ISO 649-1 codes here). So the file for German would be called Strings.de.resx.
When you're done, upload the file somewhere and let me know about it here or over on reddit.
If you know how to use Git(hub) you can of course also create a pull request.

Currently we have translations for English (d'uh), German, Spanish and Russian. Once 1.3 is released I'll keep updated lists of the added languages here (haven't decided yet if I'll keep them in the main description or the wiki page) and over on the pinned thread on Reddit.
EDIT: as of 1.3.0, I'll keep an up to date list of the included languages in the description of the current release.

If new languages get added after the release of 1.3, I'll (probably) NOT increment the version number of the program and just update the released program file, so there will be no "new version" notifications for that. If your language hasn't been added yet, just check back every once in a while to see if it was added.

@NiyaShy NiyaShy added Implemented/fixed and released and removed Implemented/fixed in testing Feature/fix is already in the testing code but not yet released as a new version labels Apr 19, 2019
@buzzcola107
Copy link

Hi, I translate in French (fr).

Strings_fr.zip

And I have a feedback/suggestions:
The other day I was playing GTAV and the warning (toast) appeared in mission over the map ( and I fail the mission lol ). And if i click on the button Shut up!, its minimizes the game (risk of crash in some game).

I ask if it is possible to just make the warning appear only for a few seconds ( like 7 seconds )

(sorry for my bad English )

I really like your software, good day and good luck !

@NiyaShy
Copy link
Owner

NiyaShy commented Apr 24, 2019

Hey,

thanks for the French translation. I'll try to add it soon-ish.

And about your other feedback, i'll split that off into a separate issue to stay on topic here.

@DrUm78
Copy link

DrUm78 commented May 3, 2019

buzzcola107 > Sorry to say that but your French translation has a few mistakes (I'm French as well). I'm gonna explain a few of those in French:

  • "Manette" est féminin, ce qui a pour conséquence tous les accords au féminin
  • les espaces insécables sont parfois oubliés (devant la ponctuation double comme ":" par exemple)
  • mieux vaut remplacer "pile" (qui en plus devrait être au pluriel quoiqu'il arrive car il y en a toujours 2) par "batterie", ce qui englobe les piles et la batterie rechargeable
  • diverses autres corrections

NiyaShy > Here is my version, which is better (please no offense in that), but can be improved for sure if needed:
Strings_fr.zip

@rybomir
Copy link

rybomir commented May 5, 2019

Hi, added Polish translation.

Strings.pl.zip

Cheers.

@NiyaShy
Copy link
Owner

NiyaShy commented May 6, 2019

Hey,
@Drumaster78 I can't really judge if your version is better than the version buzzcola107 made since my French is very basic, so I'll have to take your word for it. Added it.
@rybomir thanks, I'll add it in the next days.

@AlisaAkiron
Copy link

Hi, I translate in Chinese (zh).

Strings.zh.zip

@NiyaShy
Copy link
Owner

NiyaShy commented Jun 11, 2019

Thanks, I will add it when I find the time. But please do not spam, I got 4 notifications that you posted about your translation, one of them in an unrelated issue...

@AlisaAkiron
Copy link

I am sorry about that. I will pay attention to that in the future. :)

@KT-Yeh
Copy link

KT-Yeh commented Jun 16, 2019

Hi, I added Traditional Chinese.

Strings.zh-tw.zip

The file name I used is zh-tw because this is to distinguish between zh-cn for Simplified Chinese and zh-tw for Traditional Chinese.

@NiyaShy
Copy link
Owner

NiyaShy commented Jun 16, 2019

Hey, thanks for the translation. Just tried adding both yours and the simplified version and it seems to work fine when the resx files have the "extended" codes (zh-cn and zh-tw). Will upload the updated version soon-ish, probably today.

@iury
Copy link

iury commented Jun 22, 2019

Hello,

I've translated to Brazilian Portuguese.

Strings.pt-br.zip

Cheers

@Friday-The13-rus
Copy link

Hey, thanks for the translation. Just tried adding both yours and the simplified version and it seems to work fine when the resx files have the "extended" codes (zh-cn and zh-tw). Will upload the updated version soon-ish, probably today.

Sure, all "extended" or region-specific language codes are also supported.

@Fridolin2269
Copy link

Thanks for the nice app.
Here is the translation to Danish.
Strings.da.zip

@NiyaShy
Copy link
Owner

NiyaShy commented Aug 23, 2019

@iury sorry, somehow I missed (or forgot) about your translation. Will add it soon-ish.
@Fridolin2269 thanks, but it seems your file has some encoding issues. Visual Studio complains about invalid characters and Notepad++ shows characters that apparently aren't a part of the UTF-8 charset. See here. Please fix those.

@Fridolin2269
Copy link

@NiyaShy @Fridolin2269 . Here is another translation without danish and norwegian special characters.
Hope it works this time.
Strings.da.zip

@NiyaShy
Copy link
Owner

NiyaShy commented Aug 23, 2019

@Fridolin2269 sorry, but there are still unknown characters in it, on line 139, 154 and 157. Don't know much about Danish, but aren't the special characters part of unicode/UTF-8? Would be kinda weird considering that even all the asian languages and their special characters are included.

I just tried to look it up, and apparently characters like ø or æ are a part of UTF-8. What kind of characters were you trying to use? And what program did you use to edit the file? If you can, please try it with a text editor like Notepad++ and set it to UTF-8 encoding (without BOM). That way you should be able to see right away if a character you typed was encoded wrong.

@Fridolin2269
Copy link

Fridolin2269 commented Aug 24, 2019

@NiyaShy have now made the change in notepad++ with UTF-8 encoding (without BOM), so hopefully it works this time. Sorry for the inconvenience.
Strings.da.zip

@NiyaShy
Copy link
Owner

NiyaShy commented Aug 24, 2019

Looking good this time, no weird characters and so far VS hasn't complained.

And no problem, with that hot mess of different encoding types that exist around the world it can always happen that small issues occur. Thanks for the translation, will upload it soon-ish.

@gongwonchong
Copy link

i translated korean. i hopefully works fine.
Strings.kr.zip

@NiyaShy
Copy link
Owner

NiyaShy commented Sep 7, 2019

Hey, thanks for the translation. No issues with it, but the language code was wrong (kr is Kanuri, Korean is ko).
Just uploaded the new version that includes it~

@djmdesign
Copy link

I didn't know unopened a case.. anyways I was thanking you

@NiyaShy NiyaShy pinned this issue Jan 3, 2020
@zeular
Copy link

zeular commented Nov 25, 2020

Hi, I have translated to swedish!
Strings.sv.resx.zip

@NiyaShy
Copy link
Owner

NiyaShy commented Oct 15, 2022

Ugh, sorry @zeular but I somehow managed to completely forget about your translation... It's now added to the code repo and I'll upload an updated exe file soon-ish.

@songmin9813
Copy link

I translated it into Japanese based on Korean.
Strings.jp.zip

@NiyaShy
Copy link
Owner

NiyaShy commented Apr 21, 2023

Thanks, I'll implement it in the next few days. Just as a side note, the language/ISO code was wrong, the code for Japanese isn't "jp" but "ja" ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests