treewide: replace stdenv.is in non nix files

[Artturin]

Cont #341407

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[SuperSandro2000]

Can we also add the commit id of the other PR to .git-blame-ignore-revs?

[emilazy]

I think we shouldn’t ignore these revisions for blame, as part of the reason to migrate off the old forms is that they’re sometimes incorrect. For instance, stdenv.hostPlatform.isDarwin in nativeBuildInputs may be wrong. Ignoring the treewide revisions makes it harder to diagnose why it’s being used. I don’t think it should increase the noise of running blames significantly, as unlike reformatting most lines remained untouched.

To put it another way, we should only ignore revisions that are unlikely to be related to answering any questions about the history of why the code is the way it is, because that’s the critical thing git blame is useful for when investigating issues.