python312Packages.premailer: drop nose dependency

[Sigmanificient]

Description of changes

• python3Packages: get rid of uses of nose #326513

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[emilazy]

The disabled definition can be dropped.

Would you be up for sourcing this from GitHub instead and applying peterbe/premailer#288 to get the test suite to run? You can use a /compare/‹base revision›…‹last PR commit›.patch URL to get a reasonably stable patch without having to fetch every single commit individually, or just vendor the /pull/‹number›.patch file in Nixpkgs.

This is an unambiguous improvement though, so I won’t block it if you don’t feel like doing that.

[Sigmanificient]

Missing imp module for python 3.12, and seems like there is a failing test on 3.11

[emilazy]

The tests don’t pass even on Python 3.11:

E           AssertionError: '<img src="{{ data | default: \'Test & <code>\' }}">' != '<img src="{{%20data%20|%20default:%20\'Test%20&amp;%20&lt;code&gt;\'%20}}">'

[pyrox0]

The tests don’t pass even on Python 3.11:

E           AssertionError: '<img src="{{ data | default: \'Test & <code>\' }}">' != '<img src="{{%20data%20|%20default:%20\'Test%20&amp;%20&lt;code&gt;\'%20}}">'

This is due to lxml having a parser difference(see reported bugs peterbe/premailer#72 and peterbe/premailer#294) in version 5.0.0 that breaks premailer. I'm not 100% sure why it does this, but I've confirmed this is the issue(pinning lxml==4.9.4 passes tests, pinning lxml==5.0.0 has broken tests with the noted error.)

I'm not sure how to resolve this, but this is definitely the issue.

[emilazy]

If it’s been broken for this long, then perhaps we should simply drop it. The only user in‐tree is paddleocr, for which it is an optional dependency for one module. I think we could live without it. Or, of course, we could just skip the test and let it be broken. Since this PR has gone inactive, @pyrox0 do you want to open a new one with whatever approach you feel is best?

[pyrox0]

I think it'll be best to drop, since the project seems inactive and there are multiple PRs trying to fix support for py3.10+ which haven't been merged, and no PRs attempting to fix the lxml issue, which just creates a hassle moving forward. Will submit a new PR dropping the package.

[emilazy]

Closing as #348580 was merged. Thank you for your work on this!