Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.pygame: 2.5.2 -> 2.6.1 #322423

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Jun 25, 2024

Description of changes

Changelog: https://github.com/pygame/pygame/releases/tag/2.6.1

cc @emilytrau

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Sep 30, 2024

There is only a single test failing:

======================================================================
FAIL: test_queue (pygame.tests.mixer_test.ChannelTypeTest.test_queue)
Ensure the Channel.queue() works correctly
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/nix/store/xmp7j0nrmayqlvqaabhmdhwnw351wzl5-python3.12-pygame-2.6.1/lib/python3.12/site-packages/pygame/tests/mixer_test.py", line 861, in test_queue
    self.assertFalse(channel.get_busy())
AssertionError: True is not false

----------------------------------------------------------------------
Ran 75 tests in 11.849s

FAILED (failures=1, skipped=1, expected failures=2)

I am not sure about how to skip it.

@GaetanLepage GaetanLepage changed the title python311Packages.pygame: 2.5.2 -> 2.6.0 python311Packages.pygame: 2.5.2 -> 2.6.1 Sep 30, 2024
@GaetanLepage GaetanLepage marked this pull request as draft September 30, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant