Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh: 2.44.0 -> 2.44.1 #289648

Merged
merged 1 commit into from
Feb 18, 2024
Merged

gh: 2.44.0 -> 2.44.1 #289648

merged 1 commit into from
Feb 18, 2024

Conversation

mfrw
Copy link
Member

@mfrw mfrw commented Feb 18, 2024

Signed-off-by: Muhammad Falak R Wani [email protected]

Description of changes

Fixes a regression:

Diff: cli/cli@v2.44.0...v2.44.1
Changelog: https://github.com/cli/cli/releases/tag/v2.44.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@mfrw mfrw closed this Feb 18, 2024
@mfrw mfrw reopened this Feb 18, 2024
Copy link
Member Author

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems, maybe due a change introduced in:

The PR check is failing.

@zowoq zowoq merged commit 212d1b8 into NixOS:master Feb 18, 2024
23 checks passed
Copy link
Contributor

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-23.11
git worktree add -d .worktree/backport-289648-to-release-23.11 origin/release-23.11
cd .worktree/backport-289648-to-release-23.11
git switch --create backport-289648-to-release-23.11
git cherry-pick -x b6c4a6dd6223d8cb2e019def289aae2e83daff09

@mfrw mfrw deleted the mfrw/gh-2.44.1 branch February 18, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants