Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'mtime' argument to streamLayeredImage #255396

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add 'mtime' argument to streamLayeredImage #255396

wants to merge 2 commits into from

Conversation

utdemir
Copy link
Member

@utdemir utdemir commented Sep 16, 2023

so 'created' can be set without invalidating the layers

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@utdemir utdemir mentioned this pull request Sep 18, 2023
Closed
@puffnfresh
Copy link
Contributor

Looks like a good approach to me. Haven't tested it.

@DanielSidhion DanielSidhion mentioned this pull request Jan 24, 2024
Closed
9 tasks
@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict labels Mar 19, 2024
@the-sun-will-rise-tomorrow
Copy link
Contributor

Looks like I accidentally opened a duplicate: #327579

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth Awaiting requested review from roberth roberth will be requested when the pull request is marked ready for review roberth is a code owner

Assignees
No one assigned
Labels
2.status: merge conflict 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@utdemir @puffnfresh @the-sun-will-rise-tomorrow @wegank