Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell.lib.composable: init #144705

Closed
wants to merge 1 commit into from
Closed

haskell.lib.composable: init #144705

wants to merge 1 commit into from

Conversation

expipiplus1
Copy link
Contributor

No changes in derivations for pkgs.haskellPackages

Derivations updated to use these functions in #142940

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@expipiplus1 expipiplus1 mentioned this pull request Nov 5, 2021
Merged
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Nov 5, 2021
@expipiplus1 expipiplus1 force-pushed the haskell-lib-composable-1 branch 2 times, most recently from 3be28d5 to 03db522 Compare November 5, 2021 12:20
@expipiplus1
haskell.lib.compose: init
651d170 
No changes in derivations for pkgs.haskellPackages
@sternenseemann
Copy link
Member

do we still need this PR?

@expipiplus1
Copy link
Contributor Author

Nope!

@expipiplus1 expipiplus1 closed this Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@maralorn maralorn Awaiting requested review from maralorn

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@expipiplus1 @sternenseemann