Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run old client test suites against current daemon #11801

Open
roberth opened this issue Nov 4, 2024 · 0 comments
Open

Run old client test suites against current daemon #11801

roberth opened this issue Nov 4, 2024 · 0 comments
Labels
protocol Things involving the daemon protocol & compatibility issues tests

Comments

@roberth
Copy link
Member

roberth commented Nov 4, 2024

Is your feature request related to a problem? Please describe.

We have CI to run the test suite with an older nix-daemon, but not the other way around.
We should test changes to the daemon with an older client.

Describe the solution you'd like

Testing with an older client would be very annoying if we had to add conditionals about the client version in the test suite.
Instead, for master CI, we could run old test suites from the -maintenance branches, and insert our new daemon into it.

This increases the maintenance burden slightly, as changes to the test infrastructure may need to be backported, but this is only occasionally needed, and the added assurance outweighs the time investment. It probably pays off in development effectiveness, as manual testing won't be needed, and mistakes are found sooner.

On the -maintenance branches, we can actually refer to "future" daemon implementations as well, and we should do it. This makes those test infra backports easier, and it could catch mistakes in backports.

Describe alternatives you've considered

Add conditionals on the client version in the test suite, just like we do with the daemon. We had some code that seemed to want to try this, but was never completed. That was removed in #11800. As mentioned, the conditionals would have been very annoying (if not infeasible).

Additional context

Priorities

Add 👍 to issues you find important.

@roberth roberth added protocol Things involving the daemon protocol & compatibility issues tests labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Things involving the daemon protocol & compatibility issues tests
Projects
None yet
Development

No branches or pull requests

1 participant