Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FromCabal.PostProcess: remove gitAnnexHook #618

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

sternenseemann
Copy link
Member

After this is merged, I'll open a corresponding PR for nixpkgs that updates cabal2nix-unstable and adjusts the overrides accordingly.

- Remove all flags that no longer exist
- Force new crypton flag on (which it seems to default to in practice
  anyways)

I've pondered whether to remove this altogether, but let's not get ahead
of ourselves yet.
These can more easily be maintained in configuration-nix.nix in nixpkgs.
The git-annex build system is not quite for eternity and has changed in
the last year, requiring extra fiddling around to install man pages, for
example.
Copy link
Member

@maralorn maralorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sternenseemann sternenseemann merged commit f8e6bf7 into master Apr 21, 2024
5 checks passed
@sternenseemann sternenseemann deleted the git-annex-post-process branch April 21, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants