Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nrf52: journaling out of bound read against invalid journal. #368

Open
sosthene-nitrokey opened this issue Oct 30, 2023 · 0 comments
Open

nrf52: journaling out of bound read against invalid journal. #368

sosthene-nitrokey opened this issue Oct 30, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@sosthene-nitrokey
Copy link
Collaborator

sosthene-nitrokey commented Oct 30, 2023 •
edited
Loading

recover_from_journal contains no bound checks when indexing into the buffers. It should use bound checks and return errors properly to avoid having a device that fails to boot.

Such a bug can only happen with a corrupted journal however.
@sosthene-nitrokey sosthene-nitrokey added the bug Something isn't working label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sosthene-nitrokey